lkml.org 
[lkml]   [2011]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 07/10] cpufreq: Add support for x86 cpuinfo auto loading
    On Wed, Dec 07, 2011 at 04:41:20PM -0800, Andi Kleen wrote:
    > diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c
    > index bce576d..069fa86 100644
    > --- a/drivers/cpufreq/powernow-k8.c
    > +++ b/drivers/cpufreq/powernow-k8.c
    > @@ -37,6 +37,7 @@
    > #include <linux/delay.h>
    >
    > #include <asm/msr.h>
    > +#include <asm/cpu_device_id.h>
    >
    > #include <linux/acpi.h>
    > #include <linux/mutex.h>
    > @@ -514,6 +515,20 @@ static int core_voltage_post_transition(struct powernow_k8_data *data,
    > return 0;
    > }
    >
    > +static struct x86_cpu_id powernow_k8_ids[] = {
    > + { X86_VENDOR_AMD, 0xf, },
    > + /* RED-PEN If HW PSTATE was a normal feature bit it could be matched here
    > + * instead of a (limited) model list.
    > + */
    > + { X86_VENDOR_AMD, 0x10, },
    > + { X86_VENDOR_AMD, 0x11, },
    > + { X86_VENDOR_AMD, 0x12, },
    > + { X86_VENDOR_AMD, 0x13, },
    > + { X86_VENDOR_AMD, 0x14, },
    > + {}

    Well, there is CPUID_8000_0007_EDX[7] which denotes the presence
    of the P-state registers. It probably could be added to
    init_scattered_cpuid_features() but there's still special handling
    needed for K8.

    Can you do both a family and a feature bit test with the autoprobing
    code?

    --
    Regards/Gruss,
    Boris.

    Advanced Micro Devices GmbH
    Einsteinring 24, 85609 Dornach
    GM: Alberto Bozzo
    Reg: Dornach, Landkreis Muenchen
    HRB Nr. 43632 WEEE Registernr: 129 19551


    \
     
     \ /
      Last update: 2011-12-08 09:53    [W:0.022 / U:29.440 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site