Messages in this thread |  | | | Date | Thu, 8 Dec 2011 09:46:29 +0100 | | From | Wolfram Sang <> | | Subject | Re: [PATCH] spi: use gpio_request_one() instead of spi_gpio_alloc() helper function |
| |
On Thu, Dec 08, 2011 at 09:36:23AM +0800, Axel Lin wrote: > 2011/12/8 Wolfram Sang <w.sang@pengutronix.de>: > > On Mon, Dec 05, 2011 at 03:50:47PM +0800, Axel Lin wrote: > >> Signed-off-by: Axel Lin <axel.lin@gmail.com> > > > > This will make the driver depend on GPIOLIB, currently it depends only > > on GENERIC_GPIO. That needs to be addressed and made sure it won't cause > > a regression for the in-kernel users. > > > Ah. You are right. > GPIOLIB can be optional or not available at all in some > architecture/configurations. > Thanks for your review.
Note that there are plans to make GPIOLIB mandatory, but we are not there yet.
-- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |[unhandled content-type:application/pgp-signature] |  |