lkml.org 
[lkml]   [2011]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] proc: remove superfluous debug output
On Tue, Dec 06, 2011 at 16:48 -0800, Andrew Morton wrote:
> > - pr_debug("proc: options = %s\n", options);
> > -
> > if (!options)
> > return 1;
>
> So it turns out that this patch is a fix against the pending
> procfs-add-hidepid=-and-gid=-mount-options.patch. Please tell people
> this sort of thing to prevent confusion.

Oops, sorry. Will do this next time.


> Also, I have a note here that Alexey has issues with
> procfs-add-hidepid=-and-gid=-mount-options.patch (it is reproduced
> below) - he suggests that it is using incorrect types. Where do we
> stand with that?

This is not a bug, surely. IMHO, it's better to have it as the longest
possible format for the future changes. It's wearily to find such %d
for pid_t instances all over the kernel if we change pid_t from int to
long.

The same question, btw:

http://www.spinics.net/lists/kernel/msg1270730.html

Probably it's better to add official point about this issue into
Documentation/ ?


Thanks,

--
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments


\
 
 \ /
  Last update: 2011-12-08 20:25    [W:0.035 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site