Messages in this thread | | | Date | Thu, 8 Dec 2011 12:43:52 -0600 | From | Scott Wood <> | Subject | Re: [PATCH 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip |
| |
On 12/08/2011 04:44 AM, LiuShuo wrote: > 于 2011年12月08日 03:11, Scott Wood 写道: >> And if we do want to make such assumptions, we could rip out all usage >> of index/column here, and just handle "oob" and "full page" cases. > The function nand_do_write_ops() in nandbase.c is a Nand internal > interface. > It always is called when application write to nand flash. (e.g. dd) > In this function, partial page write is dealt with by filling '0xff' to > buffer before data copy. > (nand_do_write_oob() is similar) > So I don't think we need to do it in our controller driver again, it > should be a job of upper layer.
If this is to be considered part of the interface contract, then perhaps do a WARN_ON() if we see an unexpected index/column? And after that, only consider full-page or full-oob possibilities.
-Scott
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |