lkml.org 
[lkml]   [2011]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 09/30] Staging: comedi: fix printk issue in pcmuio.c
    Date
    This is a patch to the pcmuio.c file that fixes up a
    printk warning found by the checkpatch.pl tool.

    Added KERN_facility levels for printks.

    Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
    ---
    drivers/staging/comedi/drivers/pcmuio.c | 23 +++++++++++------------
    1 files changed, 11 insertions(+), 12 deletions(-)

    diff --git a/drivers/staging/comedi/drivers/pcmuio.c b/drivers/staging/comedi/drivers/pcmuio.c
    index 0c5b06d..1de663e 100644
    --- a/drivers/staging/comedi/drivers/pcmuio.c
    +++ b/drivers/staging/comedi/drivers/pcmuio.c
    @@ -295,15 +295,15 @@ static int pcmuio_attach(struct comedi_device *dev, struct comedi_devconfig *it)
    irq[0] = it->options[1];
    irq[1] = it->options[2];

    - printk("comedi%d: %s: io: %lx ", dev->minor, driver.driver_name,
    - iobase);
    + printk(KERN_INFO "comedi%d: %s: io: %lx attached\n", dev->minor,
    + driver.driver_name, iobase);

    dev->iobase = iobase;

    if (!iobase || !request_region(iobase,
    thisboard->num_asics * ASIC_IOSIZE,
    driver.driver_name)) {
    - printk("I/O port conflict\n");
    + printk(KERN_ERR "I/O port conflict\n");
    return -EIO;
    }

    @@ -318,7 +318,7 @@ static int pcmuio_attach(struct comedi_device *dev, struct comedi_devconfig *it)
    * convenient macro defined in comedidev.h.
    */
    if (alloc_private(dev, sizeof(struct pcmuio_private)) < 0) {
    - printk("cannot allocate private data structure\n");
    + printk(KERN_WARNING "cannot allocate private data structure\n");
    return -ENOMEM;
    }

    @@ -337,7 +337,7 @@ static int pcmuio_attach(struct comedi_device *dev, struct comedi_devconfig *it)
    kcalloc(n_subdevs, sizeof(struct pcmuio_subdev_private),
    GFP_KERNEL);
    if (!devpriv->sprivs) {
    - printk("cannot allocate subdevice private data structures\n");
    + printk(KERN_WARNING "cannot allocate subdevice private data structures\n");
    return -ENOMEM;
    }
    /*
    @@ -348,7 +348,7 @@ static int pcmuio_attach(struct comedi_device *dev, struct comedi_devconfig *it)
    * 96-channel version of the board.
    */
    if (alloc_subdevices(dev, n_subdevs) < 0) {
    - printk("cannot allocate subdevice data structures\n");
    + printk(KERN_WARNING "cannot allocate subdevice data structures\n");
    return -ENOMEM;
    }

    @@ -436,15 +436,13 @@ static int pcmuio_attach(struct comedi_device *dev, struct comedi_devconfig *it)
    irqs.. */

    if (irq[0]) {
    - printk("irq: %u ", irq[0]);
    + printk(KERN_DEBUG "irq: %u\n", irq[0]);
    if (irq[1] && thisboard->num_asics == 2)
    - printk("second ASIC irq: %u ", irq[1]);
    + printk(KERN_DEBUG "second ASIC irq: %u\n", irq[1]);
    } else {
    - printk("(IRQ mode disabled) ");
    + printk(KERN_DEBUG "(IRQ mode disabled)\n");
    }

    - printk("attached\n");
    -
    return 1;
    }

    @@ -460,7 +458,8 @@ static int pcmuio_detach(struct comedi_device *dev)
    {
    int i;

    - printk("comedi%d: %s: remove\n", dev->minor, driver.driver_name);
    + printk(KERN_INFO "comedi%d: %s: remove\n", dev->minor,
    + driver.driver_name);
    if (dev->iobase)
    release_region(dev->iobase, ASIC_IOSIZE * thisboard->num_asics);

    --
    1.7.0.4


    \
     
     \ /
      Last update: 2011-12-08 13:55    [W:0.032 / U:0.048 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site