Messages in this thread | | | Date | Wed, 7 Dec 2011 17:14:42 +0800 | From | Shawn Guo <> | Subject | Re: [PATCH][NET] several cleanups and bugfixes for fec.c: don't munge MAC address from platform data |
| |
On Wed, Dec 07, 2011 at 09:47:37AM +0100, Lothar Waßmann wrote: > Hi, > > Shawn Guo writes: > > On Tue, Dec 06, 2011 at 11:27:13AM +0100, Lothar Waßmann wrote: > > > When the MAC address is supplied via platform_data it should be OK as > > > it is and should not be modified in case of a dual FEC setup. > > > Also copying the MAC from platform_data to the single 'macaddr' > > > variable will overwrite the MAC for the first interface in case of a > > > dual FEC setup. > > > > Hmm, I do not follow that. If 'macaddr' holds a valid mac address, > > the code path has no chance to be hit at all. Otherwise, 'macaddr' > > is just a place holder for copying mac address from pdata, in which > > case the mac address will be fixed up at the end of the function for > > dual FEC setup. > > > In case of dual FEC and MAC address provided by platform_data the > first mac address will be copied to the 'macaddr' variable with no > chance for the second interface to get its mac address assigned from > platform_data too. > Indeed. So again other than subject,
Acked-by: Shawn Guo <shawn.guo@linaro.org>
-- Regards, Shawn
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |