lkml.org 
[lkml]   [2011]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[39/80] hugetlb: release pages in the error path of hugetlb_cow()
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Hillf Danton <dhillf@gmail.com>

    commit ea4039a34c4c206d015d34a49d0b00868e37db1d upstream.

    If we fail to prepare an anon_vma, the {new, old}_page should be released,
    or they will leak.

    Signed-off-by: Hillf Danton <dhillf@gmail.com>
    Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>
    Cc: Hugh Dickins <hughd@google.com>
    Cc: Johannes Weiner <jweiner@redhat.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Michal Hocko <mhocko@suse.cz>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    mm/hugetlb.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/mm/hugetlb.c
    +++ b/mm/hugetlb.c
    @@ -2415,6 +2415,8 @@ retry_avoidcopy:
    * anon_vma prepared.
    */
    if (unlikely(anon_vma_prepare(vma))) {
    + page_cache_release(new_page);
    + page_cache_release(old_page);
    /* Caller expects lock to be held */
    spin_lock(&mm->page_table_lock);
    return VM_FAULT_OOM;



    \
     
     \ /
      Last update: 2011-12-07 18:03    [W:0.019 / U:30.204 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site