[lkml]   [2011]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[051/104] xfs: use doalloc flag in xfs_qm_dqattach_one()
    3.1-stable review patch.  If anyone has any objections, please let me know.


    From: Mitsuo Hayasaka <>

    commit db3e74b582915d66e10b0c73a62763418f54c340 upstream.

    The doalloc arg in xfs_qm_dqattach_one() is a flag that indicates
    whether a new area to handle quota information will be allocated
    if needed. Originally, it was passed to xfs_qm_dqget(), but has
    been removed by the following commit (probably by mistake):

    commit 8e9b6e7fa4544ea8a0e030c8987b918509c8ff47
    Author: Christoph Hellwig <>
    Date: Sun Feb 8 21:51:42 2009 +0100

    xfs: remove the unused XFS_QMOPT_DQLOCK flag

    As the result, xfs_qm_dqget() called from xfs_qm_dqattach_one()
    never allocates the new area even if it is needed.

    This patch gives the doalloc arg to xfs_qm_dqget() in
    xfs_qm_dqattach_one() to fix this problem.

    Signed-off-by: Mitsuo Hayasaka <>
    Cc: Alex Elder <>
    Cc: Christoph Hellwig <>
    Reviewed-by: Christoph Hellwig <>
    Signed-off-by: Ben Myers <>
    Signed-off-by: Greg Kroah-Hartman <>
    fs/xfs/xfs_qm.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/fs/xfs/xfs_qm.c
    +++ b/fs/xfs/xfs_qm.c
    @@ -674,7 +674,8 @@ xfs_qm_dqattach_one(
    * disk and we didn't ask it to allocate;
    * ESRCH if quotas got turned off suddenly.
    - error = xfs_qm_dqget(ip->i_mount, ip, id, type, XFS_QMOPT_DOWARN, &dqp);
    + error = xfs_qm_dqget(ip->i_mount, ip, id, type,
    + doalloc | XFS_QMOPT_DOWARN, &dqp);
    if (error)
    return error;

     \ /
      Last update: 2011-12-07 17:37    [W:0.023 / U:17.784 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site