lkml.org 
[lkml]   [2011]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[042/104] nl80211: fix MAC address validation
    3.1-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Eliad Peller <eliad@wizery.com>

    commit e007b857e88097c96c45620bf3b04a4e309053d1 upstream.

    MAC addresses have a fixed length. The current
    policy allows passing < ETH_ALEN bytes, which
    might result in reading beyond the buffer.

    Signed-off-by: Eliad Peller <eliad@wizery.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    net/wireless/nl80211.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/net/wireless/nl80211.c
    +++ b/net/wireless/nl80211.c
    @@ -83,8 +83,8 @@ static const struct nla_policy nl80211_p
    [NL80211_ATTR_IFINDEX] = { .type = NLA_U32 },
    [NL80211_ATTR_IFNAME] = { .type = NLA_NUL_STRING, .len = IFNAMSIZ-1 },

    - [NL80211_ATTR_MAC] = { .type = NLA_BINARY, .len = ETH_ALEN },
    - [NL80211_ATTR_PREV_BSSID] = { .type = NLA_BINARY, .len = ETH_ALEN },
    + [NL80211_ATTR_MAC] = { .len = ETH_ALEN },
    + [NL80211_ATTR_PREV_BSSID] = { .len = ETH_ALEN },

    [NL80211_ATTR_KEY] = { .type = NLA_NESTED, },
    [NL80211_ATTR_KEY_DATA] = { .type = NLA_BINARY,



    \
     
     \ /
      Last update: 2011-12-07 17:37    [W:0.019 / U:32.916 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site