lkml.org 
[lkml]   [2011]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fs, proc: Add start_data, end_data, start_brk members to /proc/$pid/stat v2
On Tue, Dec 06, 2011 at 02:08:33PM -0800, Andrew Morton wrote:
> On Mon, 5 Dec 2011 22:20:11 +0400
> Cyrill Gorcunov <gorcunov@openvz.org> wrote:
>
> > It helps to dump and restore this mm_struct members.
>
> Sorry, I'm not going to apply a patch with a changelog like that.
>

OK, I'll update it. The problem is that while we "read" this entries
from procfs, the restoration is supposed to be done via prctl interface
(the patch is in fly, and I'm trying to improve it at moment).

> It needs a full description of how this will be used and why it is
> needed. So that others can understand and evaluate the proposal, and
> any possible alternatives.
>
> Such a description would also let us see whether this is just some
> "hey, maybe we'll use this sometime" thing, in which case it should not
> yet be applied.

I understand.

>
> > fs/proc/array.c | 7 +++++--
>
> Also, every change to any procfs interface should have an associated
> change to procfs documentation. If no relevant document exists then
> heck, write one. No exceptions.
>

ok, thanks.

Cyrill


\
 
 \ /
  Last update: 2011-12-06 23:17    [from the cache]
©2003-2011 Jasper Spaans