Messages in this thread Patch in this message | | | Subject | [PATCH] usb: gadget: renesas_usbhs: Use kcalloc instead of kzalloc to allocate array | From | Thomas Meyer <> | Date | Tue, 29 Nov 2011 22:08:00 +0100 |
| |
The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read.
The semantic patch that makes this change is available in https://lkml.org/lkml/2011/11/25/107
Signed-off-by: Thomas Meyer <thomas@m3y3r.de> ---
diff -u -p a/drivers/usb/renesas_usbhs/mod_host.c b/drivers/usb/renesas_usbhs/mod_host.c --- a/drivers/usb/renesas_usbhs/mod_host.c 2011-11-28 19:36:48.033448938 +0100 +++ b/drivers/usb/renesas_usbhs/mod_host.c 2011-11-28 20:04:59.954526908 +0100 @@ -1268,7 +1268,7 @@ int usbhs_mod_host_probe(struct usbhs_pr return -ENOMEM; } - pipe_info = kzalloc(sizeof(*pipe_info) * pipe_size, GFP_KERNEL); + pipe_info = kcalloc(pipe_size, sizeof(*pipe_info), GFP_KERNEL); if (!pipe_info) { dev_err(dev, "Could not allocate pipe_info\n"); goto usbhs_mod_host_probe_err;
| |