Messages in this thread Patch in this message | | | Subject | [PATCH] USB: wusb: Use kcalloc instead of kzalloc to allocate array | From | Thomas Meyer <> | Date | Tue, 29 Nov 2011 22:08:00 +0100 |
| |
The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read.
The semantic patch that makes this change is available in https://lkml.org/lkml/2011/11/25/107
Signed-off-by: Thomas Meyer <thomas@m3y3r.de> ---
diff -u -p a/drivers/usb/wusbcore/security.c b/drivers/usb/wusbcore/security.c --- a/drivers/usb/wusbcore/security.c 2011-11-13 11:07:52.997240138 +0100 +++ b/drivers/usb/wusbcore/security.c 2011-11-28 20:06:23.831675334 +0100 @@ -354,7 +354,7 @@ int wusb_dev_4way_handshake(struct wusbh struct wusb_keydvt_in keydvt_in; struct wusb_keydvt_out keydvt_out; - hs = kzalloc(3*sizeof(hs[0]), GFP_KERNEL); + hs = kcalloc(3, sizeof(hs[0]), GFP_KERNEL); if (hs == NULL) { dev_err(dev, "can't allocate handshake data\n"); goto error_kzalloc;
| |