Messages in this thread Patch in this message | | | Subject | [PATCH] [SCSI] libsas: Use kcalloc instead of kzalloc to allocate array | From | Thomas Meyer <> | Date | Tue, 29 Nov 2011 22:08:00 +0100 |
| |
The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read.
The semantic patch that makes this change is available in https://lkml.org/lkml/2011/11/25/107
Signed-off-by: Thomas Meyer <thomas@m3y3r.de> ---
diff -u -p a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c --- a/drivers/scsi/libsas/sas_expander.c 2011-11-13 11:07:46.460470430 +0100 +++ b/drivers/scsi/libsas/sas_expander.c 2011-11-28 20:04:24.150985642 +0100 @@ -306,7 +306,7 @@ static int sas_expander_discover(struct struct expander_device *ex = &dev->ex_dev; int res = -ENOMEM; - ex->ex_phy = kzalloc(sizeof(*ex->ex_phy)*ex->num_phys, GFP_KERNEL); + ex->ex_phy = kcalloc(ex->num_phys, sizeof(*ex->ex_phy), GFP_KERNEL); if (!ex->ex_phy) return -ENOMEM;
| |