lkml.org 
[lkml]   [2011]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH repost] mm,x86: remove debug_pagealloc_enabled

* Stanislaw Gruszka <sgruszka@redhat.com> wrote:

> On Mon, Dec 05, 2011 at 12:06:56PM +0100, Ingo Molnar wrote:
> >
> > * Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> >
> > > When (no)bootmem finish operation, it pass pages to buddy allocator.
> > > Since debug_pagealloc_enabled is not set, we will do not protect pages,
> > > what is not what we want with CONFIG_DEBUG_PAGEALLOC=y.
> > >
> > > To fix remove debug_pagealloc_enabled. That variable was introduced by
> > > commit 12d6f21e "x86: do not PSE on CONFIG_DEBUG_PAGEALLOC=y" to get
> > > more CPA (change page attribude) code testing. But currently we have
> > > CONFIG_CPA_DEBUG, which test CPA.
> > >
> > > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> > > Acked-by: Mel Gorman <mgorman@suse.de>
> > > ---
> > > arch/x86/mm/pageattr.c | 6 ------
> > > include/linux/mm.h | 10 ----------
> > > init/main.c | 5 -----
> > > mm/debug-pagealloc.c | 3 ---
> > > 4 files changed, 0 insertions(+), 24 deletions(-)
> >
> > I'm getting this boot crash with the patch applied:
>
> I'm sorry for breaking the boot. I tried to reproduce problem
> on my laptop, but failed. I plan to test patch with your
> config on some other machines.
>
> On the meantime can you test attached incremental patch and
> see if it workaround the crash? I suspect memblock reuse pages
> that it passed already to buddy allocator.

That will take some time - so if you could try my config on
another box that would be great. There isnt anything special
about that box.

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-12-05 16:59    [W:0.105 / U:0.236 seconds]
©2003-2014 Jasper Spaans. Advertise on this site