lkml.org 
[lkml]   [2011]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PTP] Implement clock_getres() function correctly
On Sun, Dec 04, 2011 at 06:07:43PM +0100, Thomas Gleixner wrote:
> On Sun, 4 Dec 2011, Thomas Gleixner wrote:
>
> > clock_getres() needs to put the resolution into the provided timespec
> > and return 0 in case of success.
> >
> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> > Cc: stable@vger.kernel.org
>
> Gah, wrong version.

Thanks for spotting that weird left over (from the old posix-timer.c
code).

Acked-by: Richard Cochran <richardcochran@gmail.com>

BTW, my email address has changed. Did you see my patch for
MAINTAINERS a few weeks back? It would help when finding the current
email address.

Thanks,
Richard


> diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c
> index cf3f999..6b0c02a 100644
> --- a/drivers/ptp/ptp_clock.c
> +++ b/drivers/ptp/ptp_clock.c
> @@ -101,7 +101,10 @@ static s32 scaled_ppm_to_ppb(long ppm)
>
> static int ptp_clock_getres(struct posix_clock *pc, struct timespec *tp)
> {
> - return 1; /* always round timer functions to one nanosecond */
> + /* Resolution is one nanosecond */
> + tp->tv_sec = 0;
> + tp->tv_nsec = 1;
> + return 0;
> }
>
> static int ptp_clock_settime(struct posix_clock *pc, const struct timespec *tp)
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/


\
 
 \ /
  Last update: 2011-12-05 08:35    [W:0.046 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site