[lkml]   [2011]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/2] staging: vt6656: aes_ccmp, baseband, bssdb, card: Change BOOL to int
On Sun, Dec 04, 2011 at 11:12:46PM -0200, Marcos Paulo de Souza wrote:
> This patch change all references of BOOL to int. As asked by the TODO
> file of the driver, we need to remove the ttype.h, and this file do a
> typedef of int to BOOL. We don't need this.

Why not use bool? Especially inside structs bool takes up less
space than an int. Also static analysis tools care about the type.

Changing the type from int to bool is a code change so it needs
careful auditing. It's not a problem if you don't have this
hardware, but you've been sending quite a few patches for it, so I'm
curious if you do? If you did, and you made a code change then it
helps us to know if you have tested it.

dan carpenter

[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2011-12-05 07:57    [W:0.064 / U:5.608 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site