Messages in this thread | | | Date | Mon, 5 Dec 2011 10:33:16 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] backlight: add regulator support for platform_lcd driver |
| |
On Mon, Dec 05, 2011 at 07:10:03PM +0900, Kyungmin Park wrote:
> > + if (plcd->pdata->min_uV || plcd->pdata->max_uV) > > + if (regulator_set_voltage(lcd_regulator, > > + plcd->pdata->min_uV, plcd->pdata->max_uV)) > > + dev_info(plcd->us, > > + "regulator voltage set failed\n");
> Are there case to change the voltage? Doesn't it easy to set the > voltage at board file? I mean don't need to setup at drivers?
Yes, unless the driver changes the voltage it should just assume the voltage is already set up sensibly and leave it up to the board to do any configuration which is required on boot.
There is one existing driver which implements things this way in the video subsystem but that should be fixed.
| |