Messages in this thread |  | | | Date | Fri, 30 Dec 2011 23:13:29 +0100 | | Subject | Re: [PATCH 1/1] via-rhine: Fix hanging with high CPU load on low-end broads. | | From | Bjarke Istrup Pedersen <> |
| |
2011/12/30 Francois Romieu <romieu@fr.zoreil.com>: > Bjarke Istrup Pedersen <gurligebis@gentoo.org> : > [...] >> Just applied it to HEAD of net-next, and got the following compiler warning: >> drivers/net/ethernet/via/via-rhine.c:2182:13: warning: >> 'rhine_task_enable' defined but not used > > You are running with CONFIG_PM disabled and a down / up loop will not > work. The patch below should hide the latter, at least as long as the > relevant workqueue does not stall for too long... Extra cancel_work in > task_enable could work too but it will look strange. > >> Just so you know that too :)
Does not build with patch:
drivers/net/ethernet/via/via-rhine.c: In function 'rhine_open': drivers/net/ethernet/via/via-rhine.c:1539:2: error: implicit declaration of function 'rhine_task_enable' drivers/net/ethernet/via/via-rhine.c: At top level: drivers/net/ethernet/via/via-rhine.c:2183:13: warning: conflicting types for 'rhine_task_enable' drivers/net/ethernet/via/via-rhine.c:2183:13: error: static declaration of 'rhine_task_enable' follows non-static declaration drivers/net/ethernet/via/via-rhine.c:1539:2: note: previous implicit declaration of 'rhine_task_enable' was here drivers/net/ethernet/via/via-rhine.c:2183:13: warning: 'rhine_task_enable' defined but not used
Wouldn't it be an idea to move the declarations to a via-rhine.h file, and include it, to work around it, and seperate it like it should be?
/Bjarke
> Thanks for testing. > > diff --git a/drivers/net/ethernet/via/via-rhine.c b/drivers/net/ethernet/via/via-rhine.c > index c57e1da..89ced1b 100644 > --- a/drivers/net/ethernet/via/via-rhine.c > +++ b/drivers/net/ethernet/via/via-rhine.c > @@ -1536,6 +1536,7 @@ static int rhine_open(struct net_device *dev) > alloc_rbufs(dev); > alloc_tbufs(dev); > rhine_chip_reset(dev); > + rhine_task_enable(rp); > init_registers(dev); > if (debug > 2) > netdev_dbg(dev, "%s() Done - status %04x MII status: %04x\n", > -- > Ueimor > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |