lkml.org 
[lkml]   [2011]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [27/27] clockevents: Set noop handler in clockevents_exchange_device()
    On 12/29/2011 06:05 PM, Linus Torvalds wrote:
    > On Thu, Dec 29, 2011 at 4:09 AM, Jonathan Nieder<jrnieder@gmail.com> wrote:
    >>
    >> This is basically the reverse of 7c1e768974 (clockevents: prevent
    >> clockevent event_handler ending up handler_noop, 2008-09-03). The
    >> rationale for the latter still applies.
    >
    > Hmm. You seem to be right. Instead of applying this to stable, it
    > looks like we should revert it from mainline.
    >
    >> People have been reporting
    >> the analagous patch to this one causing hangs on resume in 3.1.y and
    >> 3.2 release candidates:
    >>
    >> - http://thread.gmane.org/gmane.linux.kernel/1233033
    >> - http://thread.gmane.org/gmane.linux.kernel/1233389
    >> - http://thread.gmane.org/gmane.linux.kernel/1233159
    >> - http://thread.gmane.org/gmane.linux.kernel/1227868/focus=1230877
    >>
    >> So please consider reverting it for now.
    >
    > Thomas? It does seem to be broken and there do seem to be regression
    > reports about it.
    >
    > Should I revert it, or do you have alternative fixes?
    >
    > Linus
    > --

    We (Ubuntu) are seeing this issue as well in both 3.0.13 and 3.2-rc6:

    https://lkml.org/lkml/2011/12/24/33

    Reverting that single patch alleviates the resume regression.

    rtg
    --
    Tim Gardner tim.gardner@canonical.com


    \
     
     \ /
      Last update: 2011-12-30 16:09    [W:0.022 / U:0.828 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site