lkml.org 
[lkml]   [2011]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH 6/6] video: s3c-fb: Don't keep device runtime active when open
    Date
    > -----Original Message-----
    > From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
    > Sent: Tuesday, December 27, 2011 11:16 PM
    > To: Jingoo Han; Florian Tobias Schandinat
    > Cc: linux-fbdev@vger.kernel.org; linux-kernel@vger.kernel.org; Mark Brown
    > Subject: [PATCH 6/6] video: s3c-fb: Don't keep device runtime active when open
    >
    > Allow the controller to be runtime suspended when the screen is blanked
    > by not taking a runtime reference while the device is open. This allows
    > greater system wide power savings when used with a standard application
    > layer and ensures that the screen does not blank unless requested.
    >
    > Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

    Acked-by: Jingoo Han <jg1.han@samsung.com>

    > ---
    > drivers/video/s3c-fb.c | 22 ----------------------
    > 1 files changed, 0 insertions(+), 22 deletions(-)
    >
    > diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
    > index 84cf631..0c63b69 100644
    > --- a/drivers/video/s3c-fb.c
    > +++ b/drivers/video/s3c-fb.c
    > @@ -1070,30 +1070,8 @@ static int s3c_fb_ioctl(struct fb_info *info, unsigned int cmd,
    > return ret;
    > }
    >
    > -static int s3c_fb_open(struct fb_info *info, int user)
    > -{
    > - struct s3c_fb_win *win = info->par;
    > - struct s3c_fb *sfb = win->parent;
    > -
    > - pm_runtime_get_sync(sfb->dev);
    > -
    > - return 0;
    > -}
    > -
    > -static int s3c_fb_release(struct fb_info *info, int user)
    > -{
    > - struct s3c_fb_win *win = info->par;
    > - struct s3c_fb *sfb = win->parent;
    > -
    > - pm_runtime_put_sync(sfb->dev);
    > -
    > - return 0;
    > -}
    > -
    > static struct fb_ops s3c_fb_ops = {
    > .owner = THIS_MODULE,
    > - .fb_open = s3c_fb_open,
    > - .fb_release = s3c_fb_release,
    > .fb_check_var = s3c_fb_check_var,
    > .fb_set_par = s3c_fb_set_par,
    > .fb_blank = s3c_fb_blank,
    > --
    > 1.7.7.3



    \
     
     \ /
      Last update: 2011-12-29 00:57    [W:0.024 / U:1.272 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site