Messages in this thread | | | Date | Tue, 27 Dec 2011 15:25:44 +0100 | From | Alessandro Rubini <> | Subject | Re: [PATCH -next] debugfs: add missing #ifdef HAS_IOMEM |
| |
> "debugfs: add tools to printk 32-bit registers" adds new functions > which rely on IOMEM functionality which is not present on all > architectures and therefore result in compile errors:
Ok, my fault. I was thinking everybody has it.
Acked-by: Alessandro Rubini <rubini@gnudd.com>
(on the other hand, maybe the header should have it as well? I hate ifdef so I'd better avoid it, but I don't know what the policy is in this case: compile-error for implicit declaration or link error for missing symbol? -- maybe a comment in the header is suitable?).
/alessandro
| |