lkml.org 
[lkml]   [2011]   [Dec]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/9] drivers/mfd/88pm860x-i2c.c: introduce missing kfree
On Mon, 26 Dec 2011, Mark Brown wrote:

> On Fri, Dec 23, 2011 at 06:39:26PM +0100, Julia Lawall wrote:
>> Error handling code following a kzalloc should free the allocated data. At
>> this point, chip has been allocated and some fields have been initialized,
>> but it has not been stored anywhere, so it should be freed before leaving
>> the function.
>
> With this and probably a bunch of the other corrections in this series a
> conversion to devm_kazlloc() would be a more complete fix as it prevents
> people introducing similar missing cleanup paths in future. Not sure if
> spatch can generate that automatically though...

I saw a patch for that recently, and looked into it a little bit, but I
wasn't sure what should be done. What are the criteria for using
devm_kzalloc?

julia


\
 
 \ /
  Last update: 2011-12-26 13:21    [from the cache]
©2003-2011 Jasper Spaans