Messages in this thread | | | Date | Mon, 26 Dec 2011 15:42:52 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [PATCH 1/6] memcg: fix unused variable warning |
| |
On Mon, 26 Dec 2011 08:36:52 +0200 "Kirill A. Shutemov" <kirill@shutemov.name> wrote:
> On Mon, Dec 26, 2011 at 03:25:31PM +0900, KAMEZAWA Hiroyuki wrote: > > On Sat, 24 Dec 2011 05:00:14 +0200 > > "Kirill A. Shutemov" <kirill@shutemov.name> wrote: > > > > > From: "Kirill A. Shutemov" <kirill@shutemov.name> > > > > > > mm/memcontrol.c: In function ‘memcg_check_events’: > > > mm/memcontrol.c:784:22: warning: unused variable ‘do_numainfo’ [-Wunused-variable] > > > > > > Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name> > > > > Hmm ? Doesn't this fix cause a new Warning ? > > > > mm/memcontrol.c: In function ?memcg_check_events?: > > mm/memcontrol.c:789: warning: ISO C90 forbids mixed declarations and code > > I don't see how. The result code is: > > if (unlikely(mem_cgroup_event_ratelimit(memcg, > MEM_CGROUP_TARGET_THRESH))) { > bool do_softlimit; > > #if MAX_NUMNODES > 1 > bool do_numainfo; > do_numainfo = mem_cgroup_event_ratelimit(memcg, > MEM_CGROUP_TARGET_NUMAINFO); > #endif > do_softlimit = mem_cgroup_event_ratelimit(memcg, > MEM_CGROUP_TARGET_SOFTLIMIT); > preempt_enable(); > > mem_cgroup_threshold(memcg); >
Ah. please see linux-next and rebase onto that.
Thanks, -Kame
| |