lkml.org 
[lkml]   [2011]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] scsi/sym53c8xx_2: Fix NULL pointer dereference in slave_destroy
    On 12/04/2011 02:23 AM, psomas@gentoo.org wrote:
    > From: Stratos Psomadakis <psomas@gentoo.org>
    >
    > sym53c8xx_slave_destroy unconditionally assumes that sym53c8xx_slave_alloc has
    > succesesfully allocated a sym_lcb. This can lead to a NULL pointer dereference
    > (exposed by commit 4e6c82b).
    >
    > Signed-off-by: Stratos Psomadakis <psomas@gentoo.org>
    > Cc: stable@vger.kernel.org
    > ---
    >
    > drivers/scsi/sym53c8xx_2/sym_glue.c | 4 ++++
    > 1 files changed, 4 insertions(+), 0 deletions(-)
    >
    > diff --git a/drivers/scsi/sym53c8xx_2/sym_glue.c b/drivers/scsi/sym53c8xx_2/sym_glue.c
    > index b4543f5..76432f8 100644
    > --- a/drivers/scsi/sym53c8xx_2/sym_glue.c
    > +++ b/drivers/scsi/sym53c8xx_2/sym_glue.c
    > @@ -839,6 +839,10 @@ static void sym53c8xx_slave_destroy(struct scsi_device *sdev)
    > struct sym_lcb *lp = sym_lp(tp, sdev->lun);
    > unsigned long flags;
    >
    > + /* if slave_alloc returned before allocating a sym_lcb, return */
    > + if (!lp)
    > + return;
    > +
    > spin_lock_irqsave(np->s.host->host_lock, flags);
    >
    > if (lp->busy_itlq || lp->busy_itl) {
    resent (directly to the SCSI and sym53c8xx_2 maintainers)

    --
    Stratos Psomadakis
    <psomas@gentoo.org>


    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2011-12-24 02:23    [W:0.047 / U:31.676 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site