lkml.org 
[lkml]   [2011]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 7/7] block: fix deadlock through percpu allocation in blk-cgroup
    From
    Hello,

    On Thu, Dec 22, 2011 at 5:00 PM, Vivek Goyal <vgoyal@redhat.com> wrote:
    > So this pool is global and shared by all devices (both by CFQ and
    > throttling logic). I am not sure if there are any advantages of having
    > this pool per queue. In one of the mails you mentioned that dm is having
    > one pool across many devices which defeats the purpose of having mempool.
    >
    > **********************************************************************
    > It seemed the problem was dm sharing the same pool from multiple devices
    > (which defeats the purpose of using mempool BTW)
    > *********************************************************************
    >
    > Not sure why devices sharing a mempool is a bad idea. Having a global pool
    > definitely simplifies the implementation a lot in this case.

    Ooh, sharing breaks the forward progress guarantee by mempool. blkcg
    isn't using mempool for that. It's just using it as allocation buffer
    so it isn't relevant.

    Thanks.

    --
    tejun


    \
     
     \ /
      Last update: 2011-12-23 23:57    [W:2.166 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site