lkml.org 
[lkml]   [2011]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/8] KVM: MMU: drop unsync_child_bitmap
On 12/18/2011 04:59 PM, Avi Kivity wrote:

> On 12/16/2011 12:16 PM, Xiao Guangrong wrote:
>> unsync_child_bitmap is used to record which spte has unsync page or unsync
>> children, we can set a free bit in the spte instead of it
>>
>
> unsync_child_bitmap takes one cacheline; the shadow page table takes
> 64. This will make unsync/resync much more expensive.
>


Indeed, need more thing about this patch...

> I suggest to put unsync_child_bitmap at the end (together with
> unsync_children) and simply not allocate it when unneeded (have two
> kmem_caches for the two cases).
>
>


Good point, thanks Avi.



\
 
 \ /
  Last update: 2011-12-23 05:07    [from the cache]
©2003-2011 Jasper Spaans