Messages in this thread | | | Date | Thu, 22 Dec 2011 12:49:15 -0800 | From | Andi Kleen <> | Subject | Re: [PATCH 7/8] cpufreq: Add support for x86 cpuinfo auto loading v3 |
| |
On Thu, Dec 22, 2011 at 04:29:16PM +0100, Thomas Renninger wrote: > On Thursday, December 22, 2011 01:14:41 AM Andi Kleen wrote: > > > So this should be: > > > > > > 1. added to the scattered CPUID features list; > > > 2. artificially set in the AMD-specific initialization code for the > > > older CPUs. > > > > Not sure (2) is correct. As far as I understand it's actually different > > mechanisms, just implemented by the same driver. > > > > Keeping the list for old CPUs is not a big issue anyways. > > > > Agreed with (1) > > > > Anyways someone with the hardware should do it. Thomas? > I have something. > > Andi: If you don't mind, I'll pick up your patches, > use drivers/base/cpu.c instead of cpuid driver. Then there > will never show up a cpuid version mainline. > I'll call it v4 and this patchset then depends on Kay's work.
I would prefer to keep them separated, Kay's patchkit is gigantic.
They can be always merged later, but a dependency is not really needed. It doesn't matter much whether it's in cpuid or in cpu.
> > I'll also adjust: > - the microcode typo (in patch fix) > - add a cpuid hw_pstate (new patch) > - adjust powernow-k8 to make use of it via x86cpu autoloading > (in patch adjustings) > > Tell me (best in the next hour) if something else should > still be added.
I have nothing else.
-Andi
| |