lkml.org 
[lkml]   [2011]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH UPDATED 2/2] mempool: fix first round failure behavior
    On Thu, Dec 22, 2011 at 07:58:18AM -0800, Tejun Heo wrote:
    > Hello,
    >
    > On Thu, Dec 22, 2011 at 7:20 AM, Vivek Goyal <vgoyal@redhat.com> wrote:
    > > Also mempool expects all the objects to be returned to the pool at the
    > > time of destroy. Given the fact that blkio groups are reference counted,
    > > theoritically they can be freed later.
    >
    > I removed that part but no you still can't free objects after mempool
    > destruction refcnted or not. mempool is destructed on module unload.
    > Which text would free those objects? If that's theoretically possible,
    > the code is broken.

    That's a good point. I did not think about module unload. I think then
    my current patch for allocating per cpu object from worker thread is buggy
    as on IO scheduler exit I don't try to flush the possibly in progress
    work[s].

    Thanks
    Vivek


    \
     
     \ /
      Last update: 2011-12-22 17:09    [W:4.860 / U:0.392 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site