lkml.org 
[lkml]   [2011]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 7/8] cpufreq: Add support for x86 cpuinfo auto loading v3
Date
On Thursday, December 22, 2011 01:14:41 AM Andi Kleen wrote:
> > So this should be:
> >
> > 1. added to the scattered CPUID features list;
> > 2. artificially set in the AMD-specific initialization code for the
> > older CPUs.
>
> Not sure (2) is correct. As far as I understand it's actually different
> mechanisms, just implemented by the same driver.
>
> Keeping the list for old CPUs is not a big issue anyways.
>
> Agreed with (1)
>
> Anyways someone with the hardware should do it. Thomas?
I have something.

Andi: If you don't mind, I'll pick up your patches,
use drivers/base/cpu.c instead of cpuid driver. Then there
will never show up a cpuid version mainline.
I'll call it v4 and this patchset then depends on Kay's work.

I'll also adjust:
- the microcode typo (in patch fix)
- add a cpuid hw_pstate (new patch)
- adjust powernow-k8 to make use of it via x86cpu autoloading
(in patch adjustings)

Tell me (best in the next hour) if something else should
still be added.

I'll then resend with your From: tag on top.

No idea in which tree this should end (x86-tip, because it's a
x86 feature or Greg's because no further serialization care has
to be taken. I'll vote for Greg's, I already work on his
driver-core tree on the driver-core-next branch where Kay's
stuff already is in).

I'll add everybody to CC.

Thomas


\
 
 \ /
  Last update: 2011-12-22 16:31    [W:0.177 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site