lkml.org 
[lkml]   [2011]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/5] cgroup: separate out cgroup_attach_proc error handling code
    On Tue, Dec 20, 2011 at 04:02:31PM -0800, Mandeep Singh Baines wrote:
    > > Hmm... maybe goto out_free_group_list? Duplicating cleanup on success
    > > and failure paths can lead future updaters forget one of them. The
    > > exit path in this function isn't pretty but I don't think the proposed
    > > patch improves it either.
    > >
    >
    > Should I drop the patch or add the goto? Its 5/5 so easy enough to drop
    > since nothing else depends on it.

    Yeah, let's drop it for now. Thanks.

    --
    tejun


    \
     
     \ /
      Last update: 2011-12-21 01:17    [W:3.111 / U:0.384 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site