Messages in this thread | | | Date | Tue, 20 Dec 2011 22:25:13 +0200 | Subject | Re: [PATCH v4 4/4] usb: simplify hdrc configuration | From | Felipe Contreras <> |
| |
On Tue, Dec 20, 2011 at 1:04 PM, Felipe Balbi <balbi@ti.com> wrote: > On Tue, Dec 20, 2011 at 03:15:17AM +0200, Felipe Contreras wrote: >> HDRC requires either NOP_USB_XCEIV or TWLX030_USB, and it selects the > > that's not entirely true. Like any USB Link controller, MUSB needs a PHY > to work, but can be any off-the-shelf PHY. Nokia has used isp1704 and > isp1707 for instance. I guess Nokia also used tusb1211 and none of them > are listed there.
Then have a CONFIG_MUSB_PHY menu, or whatever.
> I would rather remove all the dependencies because the person compiling > the kernel should know that a Link needs a PHY.
Are you serious? Most likely the person compiling the kernel doesn't even know what PHY really means, and just wants the USB to f*cking work.
> Maybe add a note > somewhere stating that you should enable the PHY driver for your > platform ?
You can say the same of pretty much all the dependencies in the kernel: oh, just add a note saying that this depends on that. And how would they know what a PHY driver is?
You already know the dependency, it only needs to be written down: depends on CONFIG_MUSB_PHY. And then you have a menu for CONFIG_MUSB_PHY and select the correct transceiver.
Right now it's pretty much impossible for a normal person to figure out a working configuration on his/her own without just enabling everything.
-- Felipe Contreras
| |