lkml.org 
[lkml]   [2011]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] KVM: SVM: Notify if SVM is already in use
On Thu, Dec 01, 2011 at 08:30:18PM +0200, Sasha Levin wrote:
> Currently we silently fail if SVM is already in use by a different
> virtualization technology.
>
> This is bad since it's non-obvious for the user, and its not too uncommon
> for users to have several of these installed on same host.
>
> This patch adds a message to notify the user of the problem.
>
> Cc: Joerg Roedel <joerg.roedel@amd.com>
> Cc: Avi Kivity <avi@redhat.com>
> Cc: Marcelo Tosatti <mtosatti@redhat.com>
> Cc: kvm@vger.kernel.org
> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> ---
> arch/x86/kvm/svm.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
> index e32243e..8d1a066 100644
> --- a/arch/x86/kvm/svm.c
> +++ b/arch/x86/kvm/svm.c
> @@ -587,8 +587,11 @@ static int svm_hardware_enable(void *garbage)
> int me = raw_smp_processor_id();
>
> rdmsrl(MSR_EFER, efer);
> - if (efer & EFER_SVME)
> + if (efer & EFER_SVME) {
> + printk(KERN_ERR "svm_hardware_enable: SVM already in use on CPU%d. "
> + "Are you already another hypervisor?\n", me);

Hmm, this can nicely flood dmesg on a machine with many cores :) How
about removing the CPU%d part of the message and using printk_once?


Joerg

--
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632



\
 
 \ /
  Last update: 2011-12-02 09:55    [W:0.256 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site