lkml.org 
[lkml]   [2011]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] ata: Don't use NO_IRQ in pata_of_platform driver
    On Sat, Dec 03, 2011 at 02:34:02AM +0400, Anton Vorontsov wrote:
    > On Fri, Dec 02, 2011 at 07:19:17PM +0000, Dave Martin wrote:
    > [...]
    > > > > > Drivers should not use NO_IRQ; moreover, some architectures don't
    > > > > > have it nowadays. '0' is the 'no irq' case.
    > > > > >
    > > > > > Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>
    > > > >
    > > > > Acked-by: Alan Cox <alan@linux.intel.com>
    > > >
    > > > In case if we don't want a "band-aid fix" for 3.2, here is the patch
    > > > that just does the proper fix (w/ a risk to break minor architectures).
    > >
    > > This is now broken on ARM where, for good or bad, NO_IRQ currently is
    > > used and is -1.
    > >
    > > How do we resolve it?
    >
    > One option is to test this patch on a board that is now broken:
    >
    > http://lkml.org/lkml/2011/11/10/290

    Oh, actually, reading my own patch:

    "ARM defines NO_IRQ to -1, but OF code relies on IRQ domains support,
    which returns correct ('0') value in 'no irq' case. So everything
    should be fine."


    I forgot that on ARM we use IRQ domains, so ARM should be OK.

    Do you really see any breakage, and if so, what board?

    Thanks,

    --
    Anton Vorontsov
    Email: cbouatmailru@gmail.com


    \
     
     \ /
      Last update: 2011-12-02 23:43    [W:0.020 / U:31.484 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site