Messages in this thread | | | Date | Fri, 2 Dec 2011 11:58:09 -0800 | From | Greg KH <> | Subject | Re: [PATCH 1/3] DEBUGFS: Automatically create parents for debugfs files |
| |
On Fri, Dec 02, 2011 at 08:42:19PM +0100, Andi Kleen wrote: > On Fri, Dec 02, 2011 at 11:17:24AM -0800, Greg KH wrote: > > I like this, but some documentation will probably need to be added > > somwhere saying that it's now legal to create a debugfs file with > > "this/is/a/tree" and have it all be expanded out. > > Ok. Updating the kerneldoc entries. > > > > > And yes, cleaning up the directories shouldn't be a big issue, but what > > if the directory is already there and it tries to be created again? > > Shouldn't you do a lookup first and use that dentry if it's there? > > In this case debugfs_create_dir() errors out, the caller ignores > the error and just looks it up. So yes should work.
Ah, ok, nevermind then :)
thanks,
greg k-h
| |