Messages in this thread | | | Date | Fri, 2 Dec 2011 23:28:57 +0400 | From | Cyrill Gorcunov <> | Subject | Re: [rfc 1/3] fs, proc: Add start_data, end_data, start_brk members to /proc/$pid/stat |
| |
On Fri, Dec 02, 2011 at 11:23:32AM -0800, Kees Cook wrote: > > > > I perhaps miss some history here, you mean just print 0 > > instead of 1, right? > > The history is that when "0" is seen for start_code, tools like "ps" > assumed the process was a kernel thread, so "1" was used as a hack to > not break userspace reporting. So yeah, since this is a new field, > it's fine to just do: > > + (mm && permitted) ? mm->start_data : 0, > + (mm && permitted) ? mm->end_data : 0, > + (mm && permitted) ? mm->start_brk : 0, >
Yup, thanks a lot Kees, I'll update.
Cyrill
| |