lkml.org 
[lkml]   [2011]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 01/11] MFD: DA9052 MFD core module v8
Date
> -----Original Message-----
> From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
> Sent: Thursday, November 24, 2011 5:36 PM
> To: Ashish Jangam
> Cc: arnd@arndb.de; sameo@openedhand.com; linux-kernel@vger.kernel.org;
> Dajun; linaro-dev@lists.linaro.org
> Subject: Re: [PATCH 01/11] MFD: DA9052 MFD core module v8
>
> On Fri, Nov 18, 2011 at 02:49:54PM +0530, Ashish Jangam wrote:
>
> > + da9052_i2c->bustype = BUS_I2C;
>
> bustype should be redundant now, it certianly doesn't seem to be
> referred to in this patch.
This is required in the TSI driver.
>
> > +/*
> > + * Interrupt controller support for Dilaog DA9052 PMICs.
>
> This looks very much like it could be replaced with regmap-irq. The
> code would be slightly less efficient due to the support for sparse
> interrupt registers but it'd be less code.
regmap-irq has a opaque struct regmap_irq_chip_data which has a member
irq_base and this is required for non-primary irqs registration
and also the clean-up function regmap_del_irq_chip() requires it.
So as of now I will keep the current irq implementation as it is.


\
 
 \ /
  Last update: 2011-12-02 15:01    [W:0.068 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site