Messages in this thread | | | Date | Fri, 02 Dec 2011 17:59:16 +0530 | From | Raghavendra K T <> | Subject | Re: [PATCH RFC V3 2/4] kvm hypervisor : Add a hypercall to KVM hypervisor to support pv-ticketlocks |
| |
On 12/02/2011 01:20 AM, Raghavendra K T wrote: >>> + struct kvm_mp_state mp_state; >>> + >>> + mp_state.mp_state = KVM_MP_STATE_RUNNABLE; >>> + if (vcpu) { >>> + vcpu->kicked = 1; >>> + /* Ensure kicked is always set before wakeup */ >>> + barrier(); >>> + } >>> + kvm_arch_vcpu_ioctl_set_mpstate(vcpu,&mp_state); >> >> This must only be called from the vcpu thread. > > Hmm. Okay. 'll check this. >
Yes true. kvm_arch_vcpu_ioctl_set_mpstate itself is redundant, and will remove this.
| |