Messages in this thread | | | Date | Mon, 19 Dec 2011 15:40:07 -0800 | From | Arun Sharma <> | Subject | Re: [PATCH 2/2] tracing, sched: Add delay info to sched_switch |
| |
On 12/19/11 3:34 PM, Steven Rostedt wrote: > On Tue, 2011-12-20 at 00:28 +0100, Peter Zijlstra wrote: >> On Mon, 2011-12-19 at 15:23 -0800, Arun Sharma wrote: >>> +#ifdef CONFIG_SCHEDSTATS >>> + __entry->delay = next->se.statistics.block_start ? next->se.statistics.block_start >>> + : next->se.statistics.sleep_start ? next->se.statistics.sleep_start : 0; >>> + __entry->delay = __entry->delay ? now - __entry->delay : 0; >>> +#else >>> + __entry->delay = 0; >>> +#endif >> >> I don't really like this, this should be one of those sched_*_stat >> thingies, not sched_switch(). > > Agreed.
How does:
sched_stat_sleeptime(current, now);
at the same point sound? I'll leave sched_switch() as is.
-Arun
| |