lkml.org 
[lkml]   [2011]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] tracing, sched: Add delay info to sched_switch
On 12/19/11 3:34 PM, Steven Rostedt wrote:
> On Tue, 2011-12-20 at 00:28 +0100, Peter Zijlstra wrote:
>> On Mon, 2011-12-19 at 15:23 -0800, Arun Sharma wrote:
>>> +#ifdef CONFIG_SCHEDSTATS
>>> + __entry->delay = next->se.statistics.block_start ? next->se.statistics.block_start
>>> + : next->se.statistics.sleep_start ? next->se.statistics.sleep_start : 0;
>>> + __entry->delay = __entry->delay ? now - __entry->delay : 0;
>>> +#else
>>> + __entry->delay = 0;
>>> +#endif
>>
>> I don't really like this, this should be one of those sched_*_stat
>> thingies, not sched_switch().
>
> Agreed.

How does:

sched_stat_sleeptime(current, now);

at the same point sound? I'll leave sched_switch() as is.

-Arun



\
 
 \ /
  Last update: 2011-12-20 00:43    [W:1.508 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site