lkml.org 
[lkml]   [2011]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 07/16] dynamic_debug: drop explicit !=NULL checks
    From: Jim Cromie <jim.cromie@gmail.com>

    Convert 'if (x !=NULL)' checks into 'if (x)'.

    Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
    Signed-off-by: Jason Baron <jbaron@redhat.com>
    ---
    lib/dynamic_debug.c | 11 +++++------
    1 files changed, 5 insertions(+), 6 deletions(-)

    diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
    index d232025..b199e09 100644
    --- a/lib/dynamic_debug.c
    +++ b/lib/dynamic_debug.c
    @@ -115,27 +115,26 @@ static void ddebug_change(const struct ddebug_query *query,
    list_for_each_entry(dt, &ddebug_tables, link) {

    /* match against the module name */
    - if (query->module != NULL &&
    - strcmp(query->module, dt->mod_name))
    + if (query->module && strcmp(query->module, dt->mod_name))
    continue;

    for (i = 0 ; i < dt->num_ddebugs ; i++) {
    struct _ddebug *dp = &dt->ddebugs[i];

    /* match against the source filename */
    - if (query->filename != NULL &&
    + if (query->filename &&
    strcmp(query->filename, dp->filename) &&
    strcmp(query->filename, basename(dp->filename)))
    continue;

    /* match against the function */
    - if (query->function != NULL &&
    + if (query->function &&
    strcmp(query->function, dp->function))
    continue;

    /* match against the format */
    - if (query->format != NULL &&
    - strstr(dp->format, query->format) == NULL)
    + if (query->format &&
    + !strstr(dp->format, query->format))
    continue;

    /* match against the line number range */
    --
    1.7.7.3


    \
     
     \ /
      Last update: 2011-12-19 23:15    [W:0.019 / U:31.012 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site