Messages in this thread | | | Date | Mon, 19 Dec 2011 09:00:44 +0100 | From | Sascha Hauer <> | Subject | Re: [PATCH] MXSFB: Fix driver registration |
| |
On Sun, Dec 18, 2011 at 01:58:07AM +0100, Marek Vasut wrote: > The driver should be registered with mxsfb_driver, not with mxsfb_devtype. > This caused obvious null pointer dereference and crash. > > Signed-off-by: Marek Vasut <marek.vasut@gmail.com> > Cc: Wolfgang Denk <wd@denx.de> > Cc: Stefano Babic <sbabic@denx.de> > Cc: Shawn Guo <shawn.guo@linaro.org> > Cc: Huang Shijie <b32955@freescale.com> > Cc: Axel Lin <axel.lin@gmail.com> > Cc: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
> --- > drivers/video/mxsfb.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c > index 18742c2..d29c7c0 100644 > --- a/drivers/video/mxsfb.c > +++ b/drivers/video/mxsfb.c > @@ -902,7 +902,7 @@ static struct platform_driver mxsfb_driver = { > }, > }; > > -module_platform_driver(mxsfb_devtype); > +module_platform_driver(mxsfb_driver); > > MODULE_DESCRIPTION("Freescale mxs framebuffer driver"); > MODULE_AUTHOR("Sascha Hauer, Pengutronix"); > -- > 1.7.6.4 > >
-- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |