Messages in this thread | | | Date | Mon, 19 Dec 2011 13:55:08 -0500 | From | Naoya Horiguchi <> | Subject | Re: [RFC][PATCH 2/3] pagemap: export KPF_THP |
| |
Hi,
On Mon, Dec 19, 2011 at 07:40:47PM +0100, Andi Kleen wrote: > > diff --git 3.2-rc5.orig/fs/proc/page.c 3.2-rc5/fs/proc/page.c > > index 6d8e6a9..d436fc6 100644 > > --- 3.2-rc5.orig/fs/proc/page.c > > +++ 3.2-rc5/fs/proc/page.c > > @@ -116,6 +116,11 @@ u64 stable_page_flags(struct page *page) > > if (PageHuge(page)) > > u |= 1 << KPF_HUGE; > > > > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > > + if (PageTransCompound(page)) > > + u |= 1 << KPF_THP; > > +#endif > > It would be better to have PageTransCompound be a dummy (always 0) > for !CONFIG_TRANSPARENT_HUGEPAGE and KPF_THP always defined. > This would keep ifdefery in the headers.
OK, I'll do it in the next post. Thanks for the feedback.
Naoya
| |