Messages in this thread | | | From | Stephen Warren <> | Date | Mon, 19 Dec 2011 10:29:52 -0800 | Subject | RE: [PATCH] pinctrl: rename U300 ans SIRF pin controllers |
| |
Linus Walleij wrote at Sunday, December 18, 2011 3:47 PM: > For stringen order, rename the pinmux-* pin controllers to
I'm not sure what "stringen order" is; perhaps "consistency"?
> pinctrl-* and also rename the Kconfig symbols and in-kernel > users. > > Cc: Rongjun Ying <Rongjun.Ying@csr.com> > Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Stephen Warren <swarren@nvidia.com>
Just one question though:
> diff --git a/drivers/pinctrl/pinmux-sirf.c b/drivers/pinctrl/pinctrl-sirf.c > similarity index 100% > rename from drivers/pinctrl/pinmux-sirf.c > rename to drivers/pinctrl/pinctrl-sirf.c > diff --git a/drivers/pinctrl/pinmux-u300.c b/drivers/pinctrl/pinctrl-u300.c > similarity index 100% > rename from drivers/pinctrl/pinmux-u300.c > rename to drivers/pinctrl/pinctrl-u300.c
Do you want to change the DRIVER_NAME define in those two drivers and s/pinmux/pinctrl/ there? Perhaps that's not a good idea, but I thought I'd ask in case you meant to.
-- nvpublic
| |