lkml.org 
[lkml]   [2011]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] sysfs: change permissions for /sys from 0755 to 0555
Vitaly Kuznetsov <vitty@altlinux.ru> writes:

> There is a misleading difference between /proc and /sys permissions, /proc is
> 0555 and /sys is 0755. But
> as it is impossible to create or unlink something in /sys it would be nice to
> have same permissions.

Where does this difference matter? This doesn't look like something
that could matter in practice. If this does matter in practice this
change deserves a comment and a fuller explanation.

The change itself seems reasonable and probably worth making as general
cleanup.

Eric

> Signed-off-by: Vitaly Kuznetsov <vitty@altlinux.ru>
> ---
> fs/sysfs/mount.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/sysfs/mount.c b/fs/sysfs/mount.c
> index 4974995..9d56fdd 100644
> --- a/fs/sysfs/mount.c
> +++ b/fs/sysfs/mount.c
> @@ -36,7 +36,7 @@ struct sysfs_dirent sysfs_root = {
> .s_name = "",
> .s_count = ATOMIC_INIT(1),
> .s_flags = SYSFS_DIR,
> - .s_mode = S_IFDIR | S_IRWXU | S_IRUGO | S_IXUGO,
> + .s_mode = S_IFDIR | S_IRUGO | S_IXUGO,
> .s_ino = 1,
> };


\
 
 \ /
  Last update: 2011-12-19 03:33    [from the cache]
©2003-2011 Jasper Spaans