Messages in this thread | | | Subject | Re: [PATCH] 9p: Don't use ATTR_* values from fs.h in userspace facing structs | From | Sasha Levin <> | Date | Sat, 17 Dec 2011 20:04:27 +0200 |
| |
On Sat, 2011-12-17 at 17:47 +0000, Al Viro wrote: > Look, that's the problem with exposing this stuff to protocol; you don't > get clear semantics and are you seriously asking for trouble on kernel > changes. Suppose tomorrow we get rid of e.g. ATTR_KILL_PRIV; what are you > guys going to do? Hope that no 9p server has behaviour dependent on that > flag being set or cleared? > > Don't turn the kernel internals into a part of ABI. And blind bulk remapping > of constants is exactly that...
I went with Aneesh's suggestion and did something similar to something 9p already has done before.
This is probably a good opportunity to open it up for discussion, since I currently have a block of code containing those ATTR_* defines copy-pasted from linux/fs.h in my userspace code, and thats obviously a serious wtf.
--
Sasha.
| |