lkml.org 
[lkml]   [2011]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/4] toshiba_acpi: Support alternate hotkey interfaces
Date
On Thursday 15 December 2011 19:06:09 Seth Forshee wrote:
...
> +static bool toshiba_acpi_i8042_filter(unsigned char data, unsigned char str,
> + struct serio *port)
> +{
> + if (str & 0x20)
> + return false;
> +
> + if (unlikely(data == 0xe0))
> + return false;
> +
> + if ((data & 0x7f) == TOS1900_FN_SCAN) {
> + schedule_work(&toshiba_acpi->hotkey_work);
> + return true;
> + }
What have you tried to check whether some other kind of ACPI event
is happening?
Do any acpi/SCI interrupts happen?:
watch -n1 "cat /proc/interrupts |grep acpi"

Could it by chance be an EC or other device GPE/SCI?

> +
> + return false;
> +}
> +
> +static void toshiba_acpi_hotkey_work(struct work_struct *work)
> +{
> + acpi_handle ec_handle = ec_get_handle();
> + acpi_status status;
> +
> + if (!ec_handle)
> + return;
> +
> + status = acpi_evaluate_object(ec_handle, "NTFY", NULL, NULL);
> + if (ACPI_FAILURE(status))
> + pr_err("ACPI NTFY method execution failed\n");
Why is calling NTFY needed?

...

> +static int toshiba_acpi_suspend(struct acpi_device *acpi_dev,
> + pm_message_t state)
> +{
> + struct toshiba_acpi_dev *dev = acpi_driver_data(acpi_dev);
> + u32 result;
> +
> + if (dev->hotkey_dev)
> + hci_write1(dev, HCI_HOTKEY_EVENT, HCI_HOTKEY_DISABLE, &result);
> +
> + return 0;
> +}
> +
> +static int toshiba_acpi_resume(struct acpi_device *acpi_dev)
> +{
> + struct toshiba_acpi_dev *dev = acpi_driver_data(acpi_dev);
> + u32 result;
> +
> + if (dev->hotkey_dev)
> + hci_write1(dev, HCI_HOTKEY_EVENT, HCI_HOTKEY_ENABLE, &result);
> +
> + return 0;
> +}
What are the suspend/resume funcs for?
What bad things happen without them?


Thomas


\
 
 \ /
  Last update: 2011-12-17 09:35    [W:0.094 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site