lkml.org 
[lkml]   [2011]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] misc: Fix irq leak in max8997_muic_probe error path
    From
    Date
    Current code does not properly free allocated irqs if request_threaded_irq
    returns error, fix it.

    Signed-off-by: Axel Lin <axel.lin@gmail.com>
    ---
    drivers/misc/max8997-muic.c | 6 ++----
    1 files changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/misc/max8997-muic.c b/drivers/misc/max8997-muic.c
    index 74a9448..409b7fc 100644
    --- a/drivers/misc/max8997-muic.c
    +++ b/drivers/misc/max8997-muic.c
    @@ -566,10 +566,6 @@ static int __devinit max8997_muic_probe(struct platform_device *pdev)
    "failed: irq request (IRQ: %d,"
    " error :%d)\n",
    muic_irq->irq, ret);
    -
    - for (i = i - 1; i >= 0; i--)
    - free_irq(muic_irq->irq, info);
    -
    goto err_irq;
    }
    }
    @@ -583,6 +579,8 @@ static int __devinit max8997_muic_probe(struct platform_device *pdev)
    return ret;

    err_irq:
    + while (--i >= 0)
    + free_irq(pdata->irq_base + muic_irqs[i].irq, info);
    sysfs_remove_group(&pdev->dev.kobj, &max8997_muic_group);
    err_sysfs:
    err_pdata:
    --
    1.7.5.4




    \
     
     \ /
      Last update: 2011-12-18 03:05    [W:0.034 / U:0.084 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site