Messages in this thread | | | Date | Sun, 18 Dec 2011 09:49:20 +0900 | Subject | Re: [PATCH v3] vmscan/trace: Add 'file' info to trace_mm_vmscan_lru_isolate. | From | Minchan Kim <> |
| |
On Thu, Dec 15, 2011 at 12:14 AM, Tao Ma <tm@tao.ma> wrote: > From: Tao Ma <boyu.mt@taobao.com> > > In trace_mm_vmscan_lru_isolate, we don't output 'file' > information to the trace event and it is a bit inconvenient for the > user to get the real information(like pasted below). > mm_vmscan_lru_isolate: isolate_mode=2 order=0 nr_requested=32 nr_scanned=32 > nr_taken=32 contig_taken=0 contig_dirty=0 contig_failed=0 > > 'active' can be gotten by analyzing mode(Thanks go to Minchan and Mel), > So this patch adds 'file' to the trace event and it now looks like: > mm_vmscan_lru_isolate: isolate_mode=2 order=0 nr_requested=32 nr_scanned=32 > nr_taken=32 contig_taken=0 contig_dirty=0 contig_failed=0 file=0 > > Cc: Mel Gorman <mel@csn.ul.ie> > Cc: Minchan Kim <minchan.kim@gmail.com> > Cc: Rik van Riel <riel@redhat.com> > Cc: Johannes Weiner <hannes@cmpxchg.org> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Andrew pointed out that trace_mm_vmscan_memcg_isolate is out , Otherwise, Reviewed-by: Minchan Kim <minchan@kernel.org>
-- Kind regards, Minchan Kim
| |