lkml.org 
[lkml]   [2011]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 7/8] KVM: MMU: remove the redundant get_written_sptes
    get_written_sptes is called twice in kvm_mmu_pte_write, one of them can be
    removed

    Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
    ---
    arch/x86/kvm/mmu.c | 6 ++----
    1 files changed, 2 insertions(+), 4 deletions(-)

    diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
    index 16e0642..5d0f0e3 100644
    --- a/arch/x86/kvm/mmu.c
    +++ b/arch/x86/kvm/mmu.c
    @@ -3575,7 +3575,7 @@ static u64 mmu_pte_write_fetch_gpte(struct kvm_vcpu *vcpu, gpa_t *gpa,
    * If we're seeing too many writes to a page, it may no longer be a page table,
    * or we may be forking, in which case it is better to unmap the page.
    */
    -static bool detect_write_flooding(struct kvm_mmu_page *sp, u64 *spte)
    +static bool detect_write_flooding(struct kvm_mmu_page *sp)
    {
    /*
    * Skip write-flooding detected for the sp whose level is 1, because
    @@ -3684,10 +3684,8 @@ void kvm_mmu_pte_write(struct kvm_vcpu *vcpu, gpa_t gpa,

    mask.cr0_wp = mask.cr4_pae = mask.nxe = 1;
    for_each_gfn_indirect_valid_sp(vcpu->kvm, sp, gfn, node) {
    - spte = get_written_sptes(sp, gpa, &npte);
    -
    if (detect_write_misaligned(sp, gpa, bytes) ||
    - detect_write_flooding(sp, spte)) {
    + detect_write_flooding(sp)) {
    zap_page |= !!kvm_mmu_prepare_zap_page(vcpu->kvm, sp,
    &invalid_list);
    ++vcpu->kvm->stat.mmu_flooded;
    --
    1.7.7.4


    \
     
     \ /
      Last update: 2011-12-16 11:21    [W:0.023 / U:60.588 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site