Messages in this thread Patch in this message | | | Date | Fri, 16 Dec 2011 17:59:12 -0500 | From | Steven Rostedt <> | Subject | [PATCH 6/6] x86: Add counter when debug stack is used with interrupts enabled |
| |
From: Steven Rostedt <srostedt@redhat.com>
Mathieu Desnoyers pointed out a case that can cause issues with NMIs running on the debug stack:
int3 -> interrupt -> NMI -> int3
Because the interrupt changes the stack, the NMI will not see that it preempted the debug stack. Looking deeper at this case, interrupts only happen when the int3 is from userspace or in an a location in the exception table (fixup).
userspace -> int3 -> interurpt -> NMI -> int3
All other int3s that happen in the kernel should be processed without ever enabling interrupts, as the do_trap() call will panic the kernel if it is called to process any other location within the kernel.
Adding a counter around the sections that enable interrupts while using the debug stack allows the NMI to also check that case. If the NMI sees that it either interrupted a task using the debug stack or the debug counter is non-zero, then it will have to change the IDT table to make the int3 not change stacks (which will corrupt the stack if it does).
Link: http://lkml.kernel.org/r/1323976535.23971.112.camel@gandalf.stny.rr.com
Reported-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: H. Peter Anvin <hpa@linux.intel.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Paul Turner <pjt@google.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Signed-off-by: Steven Rostedt <rostedt@goodmis.org> --- arch/x86/include/asm/processor.h | 4 ++++ arch/x86/kernel/cpu/common.c | 16 ++++++++++++++-- arch/x86/kernel/traps.c | 14 ++++++++++++++ 3 files changed, 32 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h index d748d1f..2fef5ba 100644 --- a/arch/x86/include/asm/processor.h +++ b/arch/x86/include/asm/processor.h @@ -402,6 +402,8 @@ DECLARE_PER_CPU(char *, irq_stack_ptr); DECLARE_PER_CPU(unsigned int, irq_count); extern unsigned long kernel_eflags; extern asmlinkage void ignore_sysret(void); +void inc_debug_stack_usage(void); +void dec_debug_stack_usage(void); int is_debug_stack(unsigned long addr); void zero_debug_stack(void); void reset_debug_stack(void); @@ -420,6 +422,8 @@ struct stack_canary { DECLARE_PER_CPU_ALIGNED(struct stack_canary, stack_canary); #endif static inline int is_debug_stack(unsigned long addr) { return 0; } +static inline void inc_debug_stack_usage(void) { } +static inline void dec_debug_stack_usage(void) { } static inline void zero_debug_stack(void) { } static inline void reset_debug_stack(void) { } #endif /* X86_64 */ diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index 98faeff..f1ec612 100644 --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -1093,11 +1093,23 @@ unsigned long kernel_eflags; DEFINE_PER_CPU(struct orig_ist, orig_ist); static DEFINE_PER_CPU(unsigned long, debug_stack_addr); +static DEFINE_PER_CPU(int, debug_stack_usage); + +void inc_debug_stack_usage(void) +{ + __get_cpu_var(debug_stack_usage)++; +} + +void dec_debug_stack_usage(void) +{ + __get_cpu_var(debug_stack_usage)--; +} int is_debug_stack(unsigned long addr) { - return addr <= __get_cpu_var(debug_stack_addr) && - addr > (__get_cpu_var(debug_stack_addr) - DEBUG_STKSZ); + return __get_cpu_var(debug_stack_usage) || + (addr <= __get_cpu_var(debug_stack_addr) && + addr > (__get_cpu_var(debug_stack_addr) - DEBUG_STKSZ)); } void zero_debug_stack(void) diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c index a93c5ca..d2510e7 100644 --- a/arch/x86/kernel/traps.c +++ b/arch/x86/kernel/traps.c @@ -316,9 +316,15 @@ dotraplinkage void __kprobes do_int3(struct pt_regs *regs, long error_code) return; #endif + /* + * Let others (NMI) know that the debug stack is in use + * as we may switch to the interrupt stack. + */ + inc_debug_stack_usage(); preempt_conditional_sti(regs); do_trap(3, SIGTRAP, "int3", regs, error_code, NULL); preempt_conditional_cli(regs); + dec_debug_stack_usage(); } #ifdef CONFIG_X86_64 @@ -411,6 +417,12 @@ dotraplinkage void __kprobes do_debug(struct pt_regs *regs, long error_code) SIGTRAP) == NOTIFY_STOP) return; + /* + * Let others (NMI) know that the debug stack is in use + * as we may switch to the interrupt stack. + */ + inc_debug_stack_usage(); + /* It's safe to allow irq's after DR6 has been saved */ preempt_conditional_sti(regs); @@ -418,6 +430,7 @@ dotraplinkage void __kprobes do_debug(struct pt_regs *regs, long error_code) handle_vm86_trap((struct kernel_vm86_regs *) regs, error_code, 1); preempt_conditional_cli(regs); + dec_debug_stack_usage(); return; } @@ -437,6 +450,7 @@ dotraplinkage void __kprobes do_debug(struct pt_regs *regs, long error_code) if (tsk->thread.debugreg6 & (DR_STEP | DR_TRAP_BITS) || user_icebp) send_sigtrap(tsk, regs, error_code, si_code); preempt_conditional_cli(regs); + dec_debug_stack_usage(); return; } -- 1.7.7.3
[unhandled content-type:application/pgp-signature] | |