Messages in this thread | | | Date | Fri, 16 Dec 2011 13:42:47 -0500 (EST) | Subject | Re: [PATCH net-next v1 0/6] tg3: adaptive interrupt coalescing, non-napi mode | From | David Miller <> |
| |
From: David Decotigny <decot@googlers.com> Date: Fri, 16 Dec 2011 10:19:43 -0800
> This series implements adaptive interrupt coalescing for tg3 NIC, > improving performance substancially. It also implements non-NAPI mode > for specific system loads.
I specifically removed the dynamic IRQ coalescing from this driver years ago.
It's too susceptible to state changes.
I am sure that you have some nice benchmark for which one scheme helps, but more generally it is not possible to make it such that you will avoid the case where the network flow pattern changes by the time you change the chip configuration and thus the result is suboptimal.
I highly recommend these changes are not applied, because they will hurt someone.
| |